chn/nixpkgs
1
0
Fork 0
mirror of https://github.com/CHN-beta/nixpkgs.git synced 2026-01-12 02:40:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

nixosTests.turbovnc-headless-server: Remove expected-failing test.

Browse Source 
It doesn't fail as expected anymore because
`LIBGL_DRIVERS_PATH` was removed in Mesa 24.2,
and apparently there's no replacement for it:
https://github.com/NixOS/nixpkgs/issues/328923

Given that it was removed, and
https://www.phoronix.com/news/Mesa-24.2-Modern-Interfaces
and
https://www.supergoodcode.com/long-road-to-DRIL/
saying that removes the problem it originally caused
(also for us), this test is probably superfluous
because the thing it guards against is gone.

(cherry picked from commit e1a5818d48)
This commit is contained in:
Niklas Hambüchen
2025-05-23 02:30:08 +00:00
parent ca49c4304a
commit 862e9ee91c
1 changed files with 0 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
nixos/tests/turbovnc-headless-server.nix
View File

@@ -120,24 +120,6 @@ import ./make-test-python.nix (
)
# Checks that we detect glxgears failing when
# `LIBGL_DRIVERS_PATH=/nonexistent` is set
# (in which case software rendering should not work).
def test_glxgears_failing_with_bad_driver_path():
machine.execute(
# Note trailing & for backgrounding.
"(env DISPLAY=:0 LIBGL_DRIVERS_PATH=/nonexistent glxgears -info | tee /tmp/glxgears-should-fail.stdout) 3>&1 1>&2 2>&3 | tee /tmp/glxgears-should-fail.stderr >&2 &"
)
machine.wait_until_succeeds("test -f /tmp/glxgears-should-fail.stderr")
wait_until_terminated_or_succeeds(
termination_check_shell_command="pidof glxgears",
success_check_shell_command="grep 'MESA-LOADER: failed to open swrast' /tmp/glxgears-should-fail.stderr",
get_detail_message_fn=lambda: "Contents of /tmp/glxgears-should-fail.stderr:\n"
+ machine.succeed("cat /tmp/glxgears-should-fail.stderr"),
)
machine.wait_until_fails("pidof glxgears")
# Starts glxgears, backgrounding it. Waits until it prints the `GL_RENDERER`.
# Does not quit glxgears.
def test_glxgears_prints_renderer():
@@ -158,9 +140,6 @@ import ./make-test-python.nix (
start_xvnc()
wait_until_xvnc_glx_ready()
with subtest("Ensure bad driver path makes glxgears fail"):
test_glxgears_failing_with_bad_driver_path()
with subtest("Run 3D application (glxgears)"):
test_glxgears_prints_renderer()
@@ -170,8 +149,6 @@ import ./make-test-python.nix (
# Copy files down.
machine.copy_from_vm("/tmp/glxgears.png")
machine.copy_from_vm("/tmp/glxgears.stdout")
machine.copy_from_vm("/tmp/glxgears-should-fail.stdout")
machine.copy_from_vm("/tmp/glxgears-should-fail.stderr")
machine.copy_from_vm("/tmp/Xvnc.stdout")
machine.copy_from_vm("/tmp/Xvnc.stderr")
'';