From 93dc2de29a92b3bcfb11b3f6a8c8ff8447ad162a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Na=C3=AFm=20Favier?= Date: Thu, 5 Jan 2023 14:43:03 +0100 Subject: [PATCH] maintainers: disallow `noreply.github.com` emails --- lib/tests/maintainers.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/tests/maintainers.nix b/lib/tests/maintainers.nix index f82b63649b1f..cb1e9ddd5288 100644 --- a/lib/tests/maintainers.nix +++ b/lib/tests/maintainers.nix @@ -30,6 +30,8 @@ let echo -e " githubId = $id;\n" '' ++ lib.optional (checkedAttrs.email == null && checkedAttrs.github == null && checkedAttrs.matrix == null) '' echo ${lib.escapeShellArg (lib.showOption prefix)}': At least one of `email`, `github` or `matrix` must be specified, so that users know how to reach you.' + '' ++ lib.optional (checkedAttrs.email != null && lib.hasSuffix "noreply.github.com" checkedAttrs.email) '' + echo ${lib.escapeShellArg (lib.showOption prefix)}': If an email address is given, it should allow people to reach you. If you do not want that, you can just provide `github` or `matrix` instead.' ''; in lib.deepSeq checkedAttrs checks;