From 6ff856f8db7b3b352cd31bf5b383e182a93cdf52 Mon Sep 17 00:00:00 2001 From: PerchunPak Date: Sat, 21 Jun 2025 14:59:34 +0200 Subject: [PATCH] appmenu-glib-translator: adress code review --- .../ap/appmenu-glib-translator/package.nix | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/pkgs/by-name/ap/appmenu-glib-translator/package.nix b/pkgs/by-name/ap/appmenu-glib-translator/package.nix index 88265a3086c0..310b3e5b5548 100644 --- a/pkgs/by-name/ap/appmenu-glib-translator/package.nix +++ b/pkgs/by-name/ap/appmenu-glib-translator/package.nix @@ -1,15 +1,13 @@ { lib, fetchFromGitLab, + stdenv, glib, - gtk3, + gobject-introspection, meson, ninja, pkg-config, - gobject-introspection, vala, - stdenv, - wrapGAppsHook3, }: stdenv.mkDerivation (finalAttrs: { pname = "appmenu-glib-translator"; @@ -19,7 +17,6 @@ stdenv.mkDerivation (finalAttrs: { owner = "vala-panel-project"; repo = "vala-panel-appmenu"; tag = finalAttrs.version; - fetchSubmodules = true; hash = "sha256-v5J3nwViNiSKRPdJr+lhNUdKaPG82fShPDlnmix5tlY="; }; @@ -30,19 +27,15 @@ stdenv.mkDerivation (finalAttrs: { ninja pkg-config - wrapGAppsHook3 + gobject-introspection vala ]; - buildInputs = [ - glib - gobject-introspection - gtk3 - ]; + propagatedBuildInputs = [ glib ]; meta = { - description = "GTK module that strips menus from all GTK programs, converts to MenuModel and sends to AppMenu"; - homepage = "https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/tree/${finalAttrs.version}/subprojects/appmenu-gtk-module"; + description = "Library for translating from DBusMenu to GMenuModel"; + homepage = "https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/tree/${finalAttrs.version}/subprojects/appmenu-glib-translator"; license = lib.licenses.lgpl3Plus; maintainers = with lib.maintainers; [ perchun ]; platforms = lib.platforms.linux;