chn/nixpkgs
1
0
Fork 0
mirror of https://github.com/CHN-beta/nixpkgs.git synced 2026-01-11 18:32:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

workflows/{merge_group,pr}: fail status check explicitly

Browse Source 
When the merge queue fails, the workflow currently does not post a
negative result - and GitHub Actions waits for the status check to time
out, which takes 60 minutes.

This, of course, is a waste of time and resources. By explicitly failing
the status check, we boot the PR out of the merge queue immediately.
This commit is contained in:
Wolfgang Walther
2025-09-11 18:29:05 +02:00
parent 2b1387a6f5
commit 43a8f20d58
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/merge-group.yml vendored
View File

@@ -29,7 +29,7 @@ jobs:
# This job's only purpose is to create the target for the "Required Status Checks" branch ruleset. # This job's only purpose is to create the target for the "Required Status Checks" branch ruleset.
# It "needs" all the jobs that should block the Merge Queue. # It "needs" all the jobs that should block the Merge Queue.
unlock: unlock:
if: github.event_name != 'pull_request' if: github.event_name != 'pull_request' && always()
# Modify this list to add or remove jobs from required status checks. # Modify this list to add or remove jobs from required status checks.
needs: needs:
- lint - lint
@@ -38,6 +38,8 @@ jobs:
statuses: write statuses: write
steps: steps:
- uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0 - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
env:
RESULTS: ${{ toJSON(needs.*.result) }}
with: with:
script: | script: |
const { serverUrl, repo, runId, payload } = context const { serverUrl, repo, runId, payload } = context
@@ -50,6 +52,6 @@ jobs:
// Do NOT change the name of this, otherwise the rule will not catch it anymore. // Do NOT change the name of this, otherwise the rule will not catch it anymore.
// This would prevent all PRs from merging. // This would prevent all PRs from merging.
context: 'no PR failures', context: 'no PR failures',
state: 'success', state: JSON.parse(process.env.RESULTS).every(result => result == 'success') ? 'success' : 'error',
target_url, target_url,
}) })

6
.github/workflows/pr.yml vendored
View File

@@ -127,7 +127,7 @@ jobs:
# This job's only purpose is to create the target for the "Required Status Checks" branch ruleset. # This job's only purpose is to create the target for the "Required Status Checks" branch ruleset.
# It "needs" all the jobs that should block merging a PR. # It "needs" all the jobs that should block merging a PR.
unlock: unlock:
if: github.event_name != 'pull_request' if: github.event_name != 'pull_request' && always()
# Modify this list to add or remove jobs from required status checks. # Modify this list to add or remove jobs from required status checks.
needs: needs:
- check - check
@@ -139,6 +139,8 @@ jobs:
statuses: write statuses: write
steps: steps:
- uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0 - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
env:
RESULTS: ${{ toJSON(needs.*.result) }}
with: with:
script: | script: |
const { serverUrl, repo, runId, payload } = context const { serverUrl, repo, runId, payload } = context
@@ -151,6 +153,6 @@ jobs:
// Do NOT change the name of this, otherwise the rule will not catch it anymore. // Do NOT change the name of this, otherwise the rule will not catch it anymore.
// This would prevent all PRs from merging. // This would prevent all PRs from merging.
context: 'no PR failures', context: 'no PR failures',
state: 'success', state: JSON.parse(process.env.RESULTS).every(status => status == 'success') ? 'success' : 'error',
target_url, target_url,
}) })