From 25a0ee08173d87388d07af6fda634164b848c0d5 Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Tue, 17 Jun 2025 09:40:10 +0200 Subject: [PATCH] workflows/labels: fix approved-by-maintainer label Due to a type mismatch, maintainer approvals were never counted as such. The API returns integers for the user IDs, but the JSON file has strings as object keys. --- .github/workflows/labels.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/labels.yml b/.github/workflows/labels.yml index a694f3b1c1ac..37eb51abdecd 100644 --- a/.github/workflows/labels.yml +++ b/.github/workflows/labels.yml @@ -166,7 +166,7 @@ jobs: const maintainers = new Set(Object.keys( JSON.parse(await readFile(`${pull_request.number}/maintainers.json`, 'utf-8')) - )) + ).map(m => Number.parseInt(m, 10))) // And the labels that should be there const after = JSON.parse(await readFile(`${pull_request.number}/changed-paths.json`, 'utf-8')).labels