From 604cfd90a3d187d7248445215cee0794eb02069f Mon Sep 17 00:00:00 2001
From: Rodrigo Arias Mallo <rodrigo.arias@bsc.es>
Date: Tue, 6 Apr 2021 13:02:45 +0200
Subject: [PATCH] test: add sigsegv after MPI_Finalize test

The current srun version used in MN4 returns 0 if the program crashes
after MPI_Finalize, as shown by this test.
---
 overlay.nix                  |  5 +++--
 test/reproducers/sigsegv.c   | 35 +++++++++++++++++++++++++++++++++++
 test/reproducers/sigsegv.nix | 20 ++++++++++++++++++++
 3 files changed, 58 insertions(+), 2 deletions(-)
 create mode 100644 test/reproducers/sigsegv.c
 create mode 100644 test/reproducers/sigsegv.nix

diff --git a/overlay.nix b/overlay.nix
index 75c1881..083b47a 100644
--- a/overlay.nix
+++ b/overlay.nix
@@ -214,9 +214,10 @@ let
       inherit self super bsc callPackage;
     };
 
-#    test = {
+    test = {
 #      hwloc = callPackage ./test/bugs/hwloc.nix { };
-#    };
+      sigsegv = callPackage ./test/reproducers/sigsegv.nix { };
+    };
   });
 
 in
diff --git a/test/reproducers/sigsegv.c b/test/reproducers/sigsegv.c
new file mode 100644
index 0000000..6283a24
--- /dev/null
+++ b/test/reproducers/sigsegv.c
@@ -0,0 +1,35 @@
+#include <mpi.h>
+#include <stdio.h>
+#include <signal.h>
+#include <stdlib.h>
+
+void sigsegv(int rank)
+{
+        if (rank == 2) raise(SIGSEGV);
+}
+
+int main(int argc, char *argv[])
+{
+        int rank;
+        char where;
+
+        MPI_Init(&argc, &argv);
+
+        if(!argv[1])
+        {
+                fprintf(stderr, "missing \"before\" or \"after\" argument\n");
+                exit(1);
+        }
+
+        MPI_Comm_rank(MPI_COMM_WORLD, &rank);
+
+        where = argv[1][0];
+
+        if(where == 'b') sigsegv(rank);
+
+        MPI_Finalize();
+
+        if(where == 'a') sigsegv(rank);
+
+        return 0;
+}
diff --git a/test/reproducers/sigsegv.nix b/test/reproducers/sigsegv.nix
new file mode 100644
index 0000000..783049c
--- /dev/null
+++ b/test/reproducers/sigsegv.nix
@@ -0,0 +1,20 @@
+{
+  stdenv
+, mpi
+}:
+
+stdenv.mkDerivation {
+  name = "sigsegv";
+
+  src = ./.;
+
+  buildInputs = [ mpi ];
+
+  buildPhase = ''
+    mpicc sigsegv.c -o sigsegv
+  '';
+
+  installPhase = ''
+    cp sigsegv $out
+  '';
+}